[
https://issues.apache.org/jira/browse/YARN-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682444#comment-13682444
]
Zhijie Shen commented on YARN-803:
----------------------------------
It sounds a good idea to support polymorphy of config validation. The patch
looks almost fine. Here's two minor suggestions:
1. As all schedulers have implemented setConf, how about defining it in
YarnScheduler as well? Therefore, the newly added scheduler in the future will
also be forced to implement the method to validate its config (probably it have
to do so).
2. setConf sounds a bit confusing, because the method doesn't set the config,
but validate it. How about renaming it as validateConf?
> factor out scheduler config validation from the ResourceManager to each
> scheduler implementation
> ------------------------------------------------------------------------------------------------
>
> Key: YARN-803
> URL: https://issues.apache.org/jira/browse/YARN-803
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager, scheduler
> Affects Versions: 2.0.4-alpha
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Attachments: YARN-803.patch
>
>
> Per discussion in YARN-789 we should factor out from the ResourceManager
> class the scheduler config validations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
