[
https://issues.apache.org/jira/browse/YARN-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13684041#comment-13684041
]
Omkar Vinit Joshi commented on YARN-693:
----------------------------------------
bq. NMToken should be in org.apache.hadoop.yarn.api.records.
bq. Similarly NMTokenPBIMpl in org.apache.hadoop.yarn.api.records.impl.pb.
fixed.
bq. AMRMClient signature can just have a ConcurrentMap instead of
ConcurrentHashMap.
fixed.
bq. I suppose that the test to verify that the previously given out tokens
before roll-over will work after roll-over is in YARN-694, right?
yes there are more scenarios which will be tested in YARN-694.
bq. TestAMRMClient: Also validate NMTokens <= nodeCount ?
fixed.
bq. Static factory for NMToken?
bq. And then use the above in NMTokenSecretManagerInRM.
fixed. added static method in NMTokenIdentifier.newNMToken.
bq. The MR changes can be moved to YARN-694 or its MR companion.
I have commented out the code. will uncomment it after YARN-694 :)
bq. The correct place for calling register and unregister with
NMTokenSecretManagerInRM is RMAppAttemptImpl.
I think ApplicationMasterService looks good as it is easier to follow. keeping
it in ApplicationMasterService only.
> Sending NMToken to AM on allocate call
> --------------------------------------
>
> Key: YARN-693
> URL: https://issues.apache.org/jira/browse/YARN-693
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Omkar Vinit Joshi
> Assignee: Omkar Vinit Joshi
> Attachments: YARN-693-20130610.patch, YARN-693-20130613.patch
>
>
> This is part of YARN-613.
> As per the updated design, AM will receive per NM, NMToken in following
> scenarios
> * AM is receiving first container on underlying NM.
> * AM is receiving container on underlying NM after either NM or RM rebooted.
> ** After RM reboot, as RM doesn't remember (persist) the information about
> keys issued per AM per NM, it will reissue tokens in case AM gets new
> container on underlying NM. However on NM side NM will still retain older
> token until it receives new token to support long running jobs (in work
> preserving environment).
> ** After NM reboot, RM will delete the token information corresponding to
> that AM for all AMs.
> * AM is receiving container on underlying NM after NMToken master key is
> rolled over on RM side.
> In all the cases if AM receives new NMToken then it is suppose to store it
> for future NM communication until it receives a new one.
> AMRMClient should expose these NMToken to client.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
