[
https://issues.apache.org/jira/browse/YARN-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13685651#comment-13685651
]
Hitesh Shah commented on YARN-727:
----------------------------------
Comments:
- Usage/helper documentation for ApplicationCLI has not been updated for
--list.
- TestYarnCLI.java does not test the new appType argument
- In ClientRMService#getAllApplications,
"application.createAndGetApplicationReport" is being called twice in the for
loop.
Also, the code could be made a bit more optimal:
{code}
for (RMApp application : this.rmContext.getRMApps().values()) {
String appType = application.getApplicationType();
if (!(bypassFilter || applicationType.equals(appType))) {
continue;
}
boolean allowAccess = checkAccess(callerUGI, application.getUser(),
ApplicationAccessType.VIEW_APP, application.getApplicationId());
reports.add(application.createAndGetApplicationReport(allowAccess));
}
{code}
> ClientRMProtocol.getAllApplications should accept ApplicationType as a
> parameter
> --------------------------------------------------------------------------------
>
> Key: YARN-727
> URL: https://issues.apache.org/jira/browse/YARN-727
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 2.1.0-beta
> Reporter: Siddharth Seth
> Assignee: Xuan Gong
> Attachments: YARN-727.1.patch, YARN-727.2.patch, YARN-727.3.patch,
> YARN-727.4.patch, YARN-727.5.patch, YARN-727.6.patch, YARN-727.7.patch,
> YARN-727.8.patch, YARN-727.9.patch
>
>
> Now that an ApplicationType is registered on ApplicationSubmission,
> getAllApplications should be able to use this string to query for a specific
> application type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
