[ 
https://issues.apache.org/jira/browse/YARN-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13686720#comment-13686720
 ] 

Arun C Murthy commented on YARN-553:
------------------------------------

I edited jira description to reflect actual intent.

How about having just one api: createApplication which return 
ApplicationSubmissionContext and deleting getNewApplication? We don't need 
multiple flavours of getNewApplicationSubmission context, getNewApplication 
etc. Simplifies the end-user api. Thoughts?
                
> Have YarnClient generate a directly usable ApplicationSubmissionContext
> -----------------------------------------------------------------------
>
>                 Key: YARN-553
>                 URL: https://issues.apache.org/jira/browse/YARN-553
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client
>    Affects Versions: 2.0.3-alpha
>            Reporter: Harsh J
>            Assignee: Karthik Kambatla
>            Priority: Minor
>         Attachments: yarn-553-1.patch, yarn-553-2.patch
>
>
> Right now, we're doing multiple steps to create a relevant 
> ApplicationSubmissionContext for a pre-received GetNewApplicationResponse.
> {code}
>     GetNewApplicationResponse newApp = yarnClient.getNewApplication();
>     ApplicationId appId = newApp.getApplicationId();
>     ApplicationSubmissionContext appContext = 
> Records.newRecord(ApplicationSubmissionContext.class);
>     appContext.setApplicationId(appId);
> {code}
> A simplified way may be to have the GetNewApplicationResponse itself provide 
> a helper method that builds a usable ApplicationSubmissionContext for us. 
> Something like:
> {code}
> GetNewApplicationResponse newApp = yarnClient.getNewApplication();
> ApplicationSubmissionContext appContext = 
> newApp.generateApplicationSubmissionContext();
> {code}
> [The above method can also take an arg for the container launch spec, or 
> perhaps pre-load defaults like min-resource, etc. in the returned object, 
> aside of just associating the application ID automatically.]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to