[
https://issues.apache.org/jira/browse/YARN-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636934#comment-15636934
]
Arun Suresh edited comment on YARN-5823 at 11/4/16 4:43 PM:
------------------------------------------------------------
Thanks for the patch [~kkaranasos].
I am thinking a simpler fix would be to just replace
{{if (!allocation.getContainers().isEmpty())}} in line 545 of
{{ApplicationMasterService}} with
{{if (!allocation.getNMTokens().isEmpty())}}
This also retains the guarantee that the {{pullUpdatedNMTokens()}} and
{{allocation.getNMTokens()}} is called exactly once per allocate call.
Ideally I would also like to pull all the opportunistic containers from the
{{Allocation}} object as well, but that can be handled as part of YARN-5688
was (Author: asuresh):
Thanks for the patch [~kkaranasos].
I am thinking a simpler fix would be to just replace
{{if (!allocation.getContainers().isEmpty())}} in line 545 of
{{ApplicationMasterService}} with
{{if (!allocation.getNMTokens().isEmpty())}}
This also retains the guarantee that the {{pullUpdatedNMTokens()}} and
{{allocation.getNMTokens()}} is called exactly once per allocate call.
> Update NMTokens in case of requests with only opportunistic containers
> ----------------------------------------------------------------------
>
> Key: YARN-5823
> URL: https://issues.apache.org/jira/browse/YARN-5823
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Konstantinos Karanasos
> Assignee: Konstantinos Karanasos
> Priority: Blocker
> Attachments: YARN-5823.001.patch, YARN-5823.002.patch
>
>
> At the moment, when an {{AllocateRequest}} contains only opportunistic
> {{ResourceRequests}}, the updated NMTokens are not properly added to the
> {{AllocateResponse}}.
> In such a case the AM does not get back the needed NMTokens that are required
> to start the opportunistic containers at the respective nodes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
