[
https://issues.apache.org/jira/browse/YARN-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15642084#comment-15642084
]
Naganarasimha G R commented on YARN-4330:
-----------------------------------------
Hi [~varun_saxena],
Jenkins failed tests seems to pass for me locally and Overall the patch looks
fine except for the following nits :
# ContainersMonitorImpl.java, ln no 186: do we need this additional check
{{monitoringInterval > 0;}} as there is already boolean
configuration(*"yarn.nodemanager.container-monitor.enabled"*) for it i feel
these checks are not required.
# NodeManagerHardwareUtils.java, ln no 40: name *"isEnabled"* can be modified
to {{isHardwareDetectionEnabled}} ?
Other changes seems to be reorganization, so i am ok with other changes.
> MiniYARNCluster is showing multiple Failed to instantiate default resource
> calculator warning messages.
> --------------------------------------------------------------------------------------------------------
>
> Key: YARN-4330
> URL: https://issues.apache.org/jira/browse/YARN-4330
> Project: Hadoop YARN
> Issue Type: Bug
> Components: test, yarn
> Affects Versions: 2.8.0
> Environment: OSX, JUnit
> Reporter: Steve Loughran
> Assignee: Varun Saxena
> Priority: Blocker
> Labels: oct16-hard
> Attachments: YARN-4330.002.patch, YARN-4330.01.patch
>
>
> Whenever I try to start a MiniYARNCluster on Branch-2 (commit #0b61cca), I
> see multiple stack traces warning me that a resource calculator plugin could
> not be created
> {code}
> (ResourceCalculatorPlugin.java:getResourceCalculatorPlugin(184)) -
> java.lang.UnsupportedOperationException: Could not determine OS: Failed to
> instantiate default resource calculator.
> java.lang.UnsupportedOperationException: Could not determine OS
> {code}
> This is a minicluster. It doesn't need resource calculation. It certainly
> doesn't need test logs being cluttered with even more stack traces which will
> only generate false alarms about tests failing.
> There needs to be a way to turn this off, and the minicluster should have it
> that way by default.
> Being ruthless and marking as a blocker, because its a fairly major
> regression for anyone testing with the minicluster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
