[ 
https://issues.apache.org/jira/browse/YARN-5820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643314#comment-15643314
 ] 

Naganarasimha G R commented on YARN-5820:
-----------------------------------------

Thanks [~ajithshetty] for the patch, 
IMO instead of {{"usage: node"}} we can have {{ "usage: yarn node"}} like other 
commands,
and agree with sunil's first comment but for 2nd point, feel "-help" is not 
required as its not captured in other commands and as well this is the content 
of help also

> yarn node CLI help should be clearer
> ------------------------------------
>
>                 Key: YARN-5820
>                 URL: https://issues.apache.org/jira/browse/YARN-5820
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 2.6.0
>            Reporter: Grant Sohn
>            Assignee: Ajith S
>            Priority: Trivial
>         Attachments: YARN-5820.01.patch, YARN-5820.02.patch, 
> YARN-5820.03.patch
>
>
> Current message is:
> {noformat}
> usage: node
>  -all               Works with -list to list all nodes.
>  -list              List all running nodes. Supports optional use of
>                     -states to filter nodes based on node state, all -all
>                     to list all nodes.
>  -states <States>   Works with -list to filter nodes based on input
>                     comma-separated list of node states.
>  -status <NodeId>   Prints the status report of the node.
> {noformat}
> It should be either this:
> {noformat}
> usage: yarn node [-list [-states <States>|-all] | -status <NodeId>]
>  -all               Works with -list to list all nodes.
>  -list              List all running nodes. Supports optional use of
>                     -states to filter nodes based on node state, all -all
>                     to list all nodes.
>  -states <States>   Works with -list to filter nodes based on input
>                     comma-separated list of node states.
>  -status <NodeId>   Prints the status report of the node.
> {noformat}
> or that.
> {noformat}
> usage: yarn node -list [-states <States>|-all] 
>        yarn node -status <NodeId>
>  -all               Works with -list to list all nodes.
>  -list              List all running nodes. Supports optional use of
>                     -states to filter nodes based on node state, all -all
>                     to list all nodes.
>  -states <States>   Works with -list to filter nodes based on input
>                     comma-separated list of node states.
>  -status <NodeId>   Prints the status report of the node.
> {noformat}
> The latter is the least ambiguous.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to