[
https://issues.apache.org/jira/browse/YARN-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15654839#comment-15654839
]
Carlo Curino commented on YARN-5634:
------------------------------------
[~subru] thanks for the prompt feedback. I addressed most of your points, and
discuss the rest below.
{{YarnConfiguration}}
* I think having initialization params for the policy will be useful (while the
current choice of default does not strictly needs params, I don't like
hardcoding a null or empty buffer there, as a change of default should be
limited to changes in YarnConfiguration).
{{RouterPolicyFacade}}
* I am explicitly avoiding the Charset.defaultCharset(), as this might depend
on OS/VM conf, and since the serialize/deserialize will happen on separate
machines, I want to avoid misaligned defaults which could means we need to
redeploy code to fix bugs on a live cluster (for example if we go from a
UniformRandomRouterPolicy to a WeightedRandomRouterPolicy and we realize the
VMs have different defaultCharset).
* I don't think the *if* rewrite proposed matches the semantics we need. We
need to initialize both in case a queue is not been cached before, or if the
cached copy is different. Am I missing something?
{{TestFederationPolicyFacade}}
* I am not sure I follow what you are proposing (as it is minor I will ask you
offline).
> Simplify initialization/use of RouterPolicy via a RouterPolicyFacade
> ---------------------------------------------------------------------
>
> Key: YARN-5634
> URL: https://issues.apache.org/jira/browse/YARN-5634
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Affects Versions: YARN-2915
> Reporter: Carlo Curino
> Assignee: Carlo Curino
> Labels: oct16-medium
> Attachments: YARN-5634-YARN-2915.01.patch,
> YARN-5634-YARN-2915.02.patch
>
>
> The current set of policies require some machinery to (re)initialize based on
> changes in the SubClusterPolicyConfiguration. This JIRA tracks the effort to
> hide much of that behind a simple RouterPolicyFacade, making lifecycle and
> usage of the policies easier to consumers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
