[ https://issues.apache.org/jira/browse/YARN-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655310#comment-15655310 ]
Jian He commented on YARN-5825: ------------------------------- looks good overall, looks like this method added is not used? can be removed {code} public ReentrantReadWriteLock.WriteLock getWriteLock() { return writeLock; } {code} > ProportionalPreemptionalPolicy could use readLock over LeafQueue instead of > synchronized block > ---------------------------------------------------------------------------------------------- > > Key: YARN-5825 > URL: https://issues.apache.org/jira/browse/YARN-5825 > Project: Hadoop YARN > Issue Type: Bug > Components: capacity scheduler > Reporter: Sunil G > Assignee: Sunil G > Attachments: YARN-5825.0001.patch > > > Currently in PCPP, {{synchronized (curQueue)}} is used in various places. > Such instances could be replaced with a read lock. Thank you [~jianhe] for > pointing out the same as comment > [here|https://issues.apache.org/jira/browse/YARN-2009?focusedCommentId=15626578&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15626578] -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org