[
https://issues.apache.org/jira/browse/YARN-5271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15666551#comment-15666551
]
Wei-Chiu Chuang commented on YARN-5271:
---------------------------------------
Hi [~cheersyang] thanks for the patch.
While I think the fix itself is good, the unit test part fails to show
regression if I remove the fix.
I suspect you want to init/start/stop spyClient instead of client object:
{code}
spyClient.init(conf);
spyClient.start();
assertFalse("Timeline client should be disabled when"
+ "it is failed to init",
spyClient.timelineServiceEnabled);
spyClient.stop();
{code}
Also some nitpicking:
{code}
LOG.warn("Timeline client could not be initialized "
+ "because dependency missing or incompatible,"
{code}
It reads more natural to me to say "because of missing or incompatible
dependency,".
> ATS client doesn't work with Jersey 2 on the classpath
> ------------------------------------------------------
>
> Key: YARN-5271
> URL: https://issues.apache.org/jira/browse/YARN-5271
> Project: Hadoop YARN
> Issue Type: Bug
> Components: client, timelineserver
> Affects Versions: 2.7.2
> Reporter: Steve Loughran
> Assignee: Weiwei Yang
> Labels: oct16-medium
> Attachments: YARN-5271.01.patch, YARN-5271.branch-2.01.patch
>
>
> see SPARK-15343 : once Jersey 2 is on the CP, you can't instantiate a
> timeline client, *even if the server is an ATS1.5 server and publishing is
> via the FS*
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
