[
https://issues.apache.org/jira/browse/YARN-5885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668920#comment-15668920
]
Daniel Templeton commented on YARN-5885:
----------------------------------------
Patch looks good. On the first pass, I only see trivia:
* The javadoc for {{FSAppAttempt. getStarvation()}} should end with a period
* Javadoc for {{FSLeafQueue. isStarvedForMinShare()}} and
{{isStarvedForFairShare()}} and {{FSPreemptionThread.
identifyContainersToPreempt()}} {{@return}} should not end with a period
> Cleanup YARN-4752 for merge
> ---------------------------
>
> Key: YARN-5885
> URL: https://issues.apache.org/jira/browse/YARN-5885
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: yarn-5885.1.patch
>
>
> JIRA to track changes necessary for branch merge. These include:
> # Remove names from TODOs (e.g. KK) and add JIRA numbers for follow-up work.
> # Fix tests that have been commented out in earlier patches on the branch.
> # Double check method and field visibility of newly added code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
