[
https://issues.apache.org/jira/browse/YARN-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671745#comment-15671745
]
Varun Saxena commented on YARN-5792:
------------------------------------
Thanks [~sjlee0] for the review.
Fixed all the comments.
In TimelineEntityReader#readEntities, as we get entries from HBase in reverse
sorted order (because of prefix), we don't need TreeSet. We will be using
LinkedHashSet which Rohith is using in his patch in YARN-5585. For HBase
implementation we do not need it but we can still change compareTo and use
prefix in it, so that if required the correct version is used.
As this is related to reader side changes primarily, lets do so in YARN-5585.
> adopt the id prefix for YARN, MR, and DS entities
> -------------------------------------------------
>
> Key: YARN-5792
> URL: https://issues.apache.org/jira/browse/YARN-5792
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-5355
> Reporter: Sangjin Lee
> Assignee: Varun Saxena
> Attachments: YARN-5792-YARN-5355.01.patch,
> YARN-5792-YARN-5355.02.patch, YARN-5792-YARN-5355.03.patch,
> YARN-5792-YARN-5355.04.patch, YARN-5792-YARN-5355.05.patch
>
>
> We introduced the entity id prefix to support flexible entity sorting
> (YARN-5715). We should adopt the id prefix for YARN entities, MR entities,
> and DS entities to take advantage of the id prefix.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
