[
https://issues.apache.org/jira/browse/YARN-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672602#comment-15672602
]
sandflee commented on YARN-5895:
--------------------------------
yes, I think there are two main places not drain Events:
1, explicitly using MemoryStateStore like most RMRestart test, we could resolve
by using MockRMMemoryStateStore
2, using MockRM.waitForState in static way, we could explicitly add
rm.drainEvents() before call MockRM.waitForState or change MockRM.waitForState
from static to non-static. thought?
bq. some of the tests in YARN-4929 need to look again.
will do
> TestRMRestart#testFinishedAppRemovalAfterRMRestart is still flakey
> -------------------------------------------------------------------
>
> Key: YARN-5895
> URL: https://issues.apache.org/jira/browse/YARN-5895
> Project: Hadoop YARN
> Issue Type: Bug
> Components: test
> Affects Versions: 3.0.0-alpha1
> Reporter: Wilfred Spiegelenburg
> Assignee: sandflee
>
> Even after YARN-5362 the test is still flaky:
> {code}
> Tests run: 29, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 100.652 sec
> <<< FAILURE! - in org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart
> testFinishedAppRemovalAfterRMRestart(org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart)
> Time elapsed: 0.338 sec <<< FAILURE!
> java.lang.AssertionError: expected null, but was:<submit_time: 1479326359187
> application_submission_context { application_id { id: 1 cluster_timestamp:
> 1479326359158 } application_name: "" queue: "default" priority { priority: 0
> } am_container_spec { } cancel_tokens_when_complete: true maxAppAttempts: 2
> resource { memory: 1024 virtual_cores: 1 } applicationType: "YARN"
> keep_containers_across_application_attempts: false
> attempt_failures_validity_interval: 0 am_container_resource_request {
> priority { priority: 0 } resource_name: "*" capability { memory: 1024
> virtual_cores: 1 } num_containers: 0 relax_locality: true
> node_label_expression: "" execution_type_request { execution_type: GUARANTEED
> enforce_execution_type: false } } } user: "jenkins" start_time: 1479326359188
> application_state: RMAPP_FINISHED finish_time: 1479326359214>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotNull(Assert.java:664)
> at org.junit.Assert.assertNull(Assert.java:646)
> at org.junit.Assert.assertNull(Assert.java:656)
> at
> org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.testFinishedAppRemovalAfterRMRestart(TestRMRestart.java:1659)
> {code}
> The test finishes with two asserts. This is the second assert that fails,
> YARN-5362 looked at a failure on the first of the two asserts
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
