[
https://issues.apache.org/jira/browse/YARN-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15687948#comment-15687948
]
Eric Payne commented on YARN-5889:
----------------------------------
Thanks [~sunilg] for working on this refactoring. Here are my comments for
{{YARN-5889.v1.patch}}
- CapacitySchedulerConfiguration.java:
-- {{getUserLimitAynschronously}} should be {{getUserLimitAsynchronously}}
- {{CapacitySchedule#serviceStart}}: Shouldn't this check before dereferencing
{{computeUserLimitAsyncThread}}:
{code}
public void serviceStart() throws Exception {
startSchedulerThreads();
computeUserLimitAsyncThread.start();
super.serviceStart();
}
{code}
- {{CapacitySchedule#ComputeUserLimitAsyncThread#run}}:
{code}
Thread.sleep(1);
{code}
It seems like this should be longer than 1 ms. Isn't the default scheduling
interval 5 seconds? That may be too long, but I think it should be at least a
second.
- {{CapacitySchedule#ComputeUserLimitAsyncThread#run}}:
This is just a very small nit, but it seems to me like {{getAllLeafQueues()}}
should return a list of {{LeafQueue}}'s instead of a list of {{CSQueue}}'s.
{code}
List<CSQueue> leafQueues = cs.getAllLeafQueues();
{code}
- LeafQueue.java:
Another tiny nit, but since {{computeUserLimit}} and {{getComputedUserLimit}}
have the same arguments, can the arguments to {{getComputedUserLimit}} be in
the same order as those for {{computeUserLimit}}?
- {{LeafQueue#getComputedUserLimit}}
I don't think we want to always return {{Resources.unbounded()}} when
{{userLimitPerSchedulingMode}} is null. If computing user limit the legacy way,
the return value of the {{computeUserLimit}} method should be returned.
- ActiveUsersManager.java: Is the import of FiCaSchedulerApp needed?
{code}
import
org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp;
{code}
> Improve user-limit calculation in capacity scheduler
> ----------------------------------------------------
>
> Key: YARN-5889
> URL: https://issues.apache.org/jira/browse/YARN-5889
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler
> Reporter: Sunil G
> Assignee: Sunil G
> Attachments: YARN-5889.v0.patch, YARN-5889.v1.patch
>
>
> Currently user-limit is computed during every heartbeat allocation cycle with
> a write lock. To improve performance, this tickets is focussing on moving
> user-limit calculation out of heartbeat allocation flow.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
