[
https://issues.apache.org/jira/browse/YARN-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15689152#comment-15689152
]
Vinod Kumar Vavilapalli commented on YARN-4206:
-----------------------------------------------
Few comments:
- Rename suggestions
-- getApplicationTimeoutList -> getApplicationTimeouts &
setApplicationTimeoutList -> setApplicationTimeouts
-- getAppTimeoutType -> getTimeoutType & setAppTimeoutType -> setTimeoutType
-- getExpireTime -> getExpiryTime
- Drop the "of an application" part in the javadoc everywhere to keep it open
for app, app-attempt, container timeouts? For e.g. in "Get
<code>expireTime</code> of an application for given timeout type."
- From the server side, we should always return a timeout object - for now
only with LIFETime type.
-- If an app didn't specify anything: expiry-time = "unlimited",
remaining-time = -1 (unknown)
-- If an app specified the timeout and is running, return proper values
-- If an app is finished, expiry-time = <proper value | unlimited>,
remaining-time = 0
- CLI
-- I think we should either implement (a) your earlier proposal ({{./yarn
application -updateTimeout 10 -updateType LIFETIME}}) as it is foolproof., then
madate updateType with updateTimeout and for now only support LIFETIME as a
type in the CLI or (b) have a simpler updateLifetime.
-- {code}
+ ApplicationTimeout timeout =
+ appReport.getApplicationTimeoutList().iterator().next();
+ appReportStr.print("\tApplication Expire Time : ");
+ appReportStr.println(timeout.getExpireTime());
+ appReportStr.print("\tApplication Remaining Time : ");
+ appReportStr.print(timeout.getRemainingTime());
{code}
-- We should simply iterate the timeouts and print one line for each type:
"Lifetime: expiry-time=<ISO format>, remaining-time=<long>seconds"
> Add life time value in Application report and CLI
> -------------------------------------------------
>
> Key: YARN-4206
> URL: https://issues.apache.org/jira/browse/YARN-4206
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: scheduler
> Reporter: nijel
> Assignee: Rohith Sharma K S
> Attachments: YARN-4206.2.patch, YARN-4206.3.patch, YARN-4206.4.patch,
> YARN-4506.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
