[ 
https://issues.apache.org/jira/browse/YARN-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15702479#comment-15702479
 ] 

Billie Rinaldi commented on YARN-5909:
--------------------------------------

[~jianhe], thanks for taking this on. The patch looks good so far. The 
following change in WebAppApi appears to be a typo:
{noformat}
-   * @return the (singleton) instance
+   * @return the (singleton) instancepro
{noformat}

I think we can remove the three jetty dependencies from the slider core 
pom.xml. I don't see any jetty imports except in the removed classes. It looks 
like we also need to remove the jackson-jaxrs-json-provider dependency added in 
hadoop-project/pom.xml for the services API, as this has already been added in 
YARN-5713.

Let's open a follow-up patch to remove AgentKeys. Any constants from there that 
are still being used can be moved to SliderKeys or one of the other Keys 
classes.

> Remove the agent code in slider and upgrade framework jetty version 
> --------------------------------------------------------------------
>
>                 Key: YARN-5909
>                 URL: https://issues.apache.org/jira/browse/YARN-5909
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>         Attachments: YARN-5909-yarn-native-services.01.patch
>
>
> Hadoop core has upgraded jetty version to 9 ,
> The framework (slider AM) also needs to upgrade the jetty version
> Problem is that some legacy agent code uses classes which only exist in old 
> jetty. Probably it's the time to remove all the agent related code ?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to