[ 
https://issues.apache.org/jira/browse/YARN-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15703670#comment-15703670
 ] 

Arun Suresh commented on YARN-5938:
-----------------------------------

Like I mentioned, this is mostly just a re-factoring change. [~kasha], 
[~varun_saxena] (since you helped review YARN-5918, so you might have some 
context)

> Minor refactoring to OpportunisticContainerAllocatorAMService
> -------------------------------------------------------------
>
>                 Key: YARN-5938
>                 URL: https://issues.apache.org/jira/browse/YARN-5938
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-5938.001.patch
>
>
> Minor code re-organization to do the following:
> # The OpportunisticContainerAllocatorAMService currently allocates outside 
> the ApplicationAttempt lock maintained by the ApplicationMasterService. This 
> should happen inside the lock.
> # Refactored out some code to simplify the allocate() method.
> # Removed some unused fields inside the OpportunisticContainerAllocator.
> # Re-organized some of the code in the 
> OpportunisticContainerAllocatorAMService::allocate method to make it a bit 
> more readable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to