[ https://issues.apache.org/jira/browse/YARN-5890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706139#comment-15706139 ]
Daniel Templeton commented on YARN-5890: ---------------------------------------- Thanks for the update, [~yufeigu]. Looks good. I like the assert messages. After taking a closer look at the patch, I have one outstanding concern: can you explain this math to me? {{Math.abs(maxAMShare - -1.0f}} Why subtract -1 instead of adding 1? Why subtract -1 at all? > FairScheduler should log information about AM-resource-usage and max-AM-share > for queues > ---------------------------------------------------------------------------------------- > > Key: YARN-5890 > URL: https://issues.apache.org/jira/browse/YARN-5890 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler > Reporter: Yufei Gu > Assignee: Yufei Gu > Attachments: YARN-5890.001.patch, YARN-5890.002.patch, > YARN-5890.003.patch, YARN-5890.004.patch > > > There are several cases where jobs in a queue or stuck likely because of > maxAMShare. It is hard to debug these issues without any information. > At the very least, we need to log both AM-resource-usage and max-AM-share for > queues. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org