[ 
https://issues.apache.org/jira/browse/YARN-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15725550#comment-15725550
 ] 

Sunil G commented on YARN-5970:
-------------------------------

Thanks [~rohithsharma]

1)
bq.{{throw new ParseException("Invalid input.", -1);}}
Since we do not know the error offset, do we need to set it to -1?

2)
bq.
{noformat}
"Expire time is not in ISO8601 format. ISO8601 supported "
 + "format is yyyy-MM-dd'T'HH:mm:ss.SSSZ. Configured "
 + "timeout value is " + timeout.getValue();
{noformat}

Could we append "seconds" as well at the end.

3) When app is finished before timeout, could we validate ? I think we can club 
that validation also here. Thoughts?


> Validate update timeout request parameters
> ------------------------------------------
>
>                 Key: YARN-5970
>                 URL: https://issues.apache.org/jira/browse/YARN-5970
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: scheduler
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>         Attachments: YARN-5970.0.patch
>
>
> AppTimeoutInfo is exposed to REST clients. This object request parameters 
> should be validated before processing it to clientRMService.
> And also handles couple of minor issues in REST services.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to