[
https://issues.apache.org/jira/browse/YARN-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15725677#comment-15725677
]
Sunil G commented on YARN-5965:
-------------------------------
Thanks [~rohithsharma]
Few minor nits:
{noformat}
optional string appNodeLabelExpression = 24;
optional string amNodeLabelExpression = 25;
repeated AppTimeoutMapProto application_timeouts = 26;
}
message AppTimeoutMapProto {
optional ApplicationTimeoutTypeProto application_timeout_type = 1;
optional ApplicationTimeoutProto application_timeouts = 2;
}
}
{noformat}
1. {{AppTimeoutMapProto application_timeouts}}, could it be like
{{appTimeouts}} and {{AppTimeoutsMapProto}}
2. AppTimeoutMapProto -> AppTimeoutsMapProto
3. application_timeouts -> application_timeout
> Revisit ApplicationReport #getApplicationTimeouts
> -------------------------------------------------
>
> Key: YARN-5965
> URL: https://issues.apache.org/jira/browse/YARN-5965
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: scheduler
> Reporter: Jian He
> Assignee: Rohith Sharma K S
> Attachments: YARN-5965.0.patch
>
>
> Currently it returns a list of ApplicationTimeout objects, to get a
> particular timeout, the caller code needs to iterate the list and compare the
> timeoutType to get the corresponding value. Is a map data structure easier
> for use code?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
