[ https://issues.apache.org/jira/browse/YARN-5999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749795#comment-15749795 ]
Xuan Gong commented on YARN-5999: --------------------------------- Committed to trunk/branch-2. Thanks, Jian. And thanks, [~billie.rinaldi] for the review > AMRMClientAsync will stop if any exceptions thrown on allocate call > -------------------------------------------------------------------- > > Key: YARN-5999 > URL: https://issues.apache.org/jira/browse/YARN-5999 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Jian He > Assignee: Jian He > Fix For: 2.9.0 > > Attachments: YARN-5999.1.patch > > > Currently, for any exceptions thrown on the allocate call of AMRMClientAsync, > it will stop both heartbeat thread and the callback handler thread, leaving > AMRMClient in an unusable state. Caller has to instantiate a new AMRMClient. > IMO, the threads should keep on running, it should be up to the caller > whether to stop the AMRMClient or not. > {code} > try { > response = client.allocate(progress); > } catch (ApplicationAttemptNotFoundException e) { > handler.onShutdownRequest(); > LOG.info("Shutdown requested. Stopping callback."); > return; > } catch (Throwable ex) { > LOG.error("Exception on heartbeat", ex); > savedException = ex; > // interrupt handler thread in case it waiting on the queue > handlerThread.interrupt(); > return; > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org