[
https://issues.apache.org/jira/browse/YARN-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767926#comment-15767926
]
Yufei Gu commented on YARN-5969:
--------------------------------
Thanks [~zsl2007]. I like the figures, especially the one about the allocated
container # per minute. It did improve a lot based on your figures in this
scale!
The patch looks good to me generally. Minor nits:
1. use meaningful variable names instead of "u1", "u2". It is OK to leave
"s1"/"s2" since they are already there.
2. It would be nice to put the comment about why you do this before the
following code.
{code}
Resource u1 = s1.getResourceUsage();
Resource u2 = s2.getResourceUsage();
{code}
> FairShareComparator getResourceUsage poor performance
> -----------------------------------------------------
>
> Key: YARN-5969
> URL: https://issues.apache.org/jira/browse/YARN-5969
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
> Affects Versions: 2.7.1
> Reporter: zhangshilong
> Assignee: zhangshilong
> Attachments: 20161206.patch, apprunning_after.png,
> apprunning_before.png, containerAllocatedDelta_before.png,
> containerAllocated_after.png, pending_after.png, pending_before.png
>
>
> in FairShareComparator class, the performance of function getResourceUsage()
> is very poor. It will be executed above 100,000,000 times per second.
> In our scene, It takes 20 seconds per minute.
> A simple solution is to reduce call counts of the function.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
