[
https://issues.apache.org/jira/browse/YARN-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15783370#comment-15783370
]
Karthik Kambatla commented on YARN-5798:
----------------------------------------
Thanks for picking this up, Yufei.
Comments on the patch:
# Interrupting the thread is the only way to stop the thread. So, I think we
should just return (and not transition to standby) for InterruptedException.
# For RTE, how about using a custom {{Thread.UncaughtExceptionHandler}}. Other
threads in FairScheduler do not handle RTEs either. We could use the same
handler for all these threads. Might not be a bad idea to increase the scope of
this JIRA and include those as well?
# We should also add tests.
> Handle FSPreemptionThread crashing due to a RuntimeException
> ------------------------------------------------------------
>
> Key: YARN-5798
> URL: https://issues.apache.org/jira/browse/YARN-5798
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler
> Affects Versions: 2.9.0
> Reporter: Karthik Kambatla
> Assignee: Yufei Gu
> Attachments: YARN-5798.001.patch
>
>
> YARN-5605 added an FSPreemptionThread. The run() method catches
> InterruptedException. If this were to run into a RuntimeException, the
> preemption thread would crash. We should probably fail the RM itself (or
> transition to standby) when this happens.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
