[
https://issues.apache.org/jira/browse/YARN-5585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795650#comment-15795650
]
Sangjin Lee edited comment on YARN-5585 at 1/3/17 5:53 PM:
-----------------------------------------------------------
I'm back at work, and am going over the discussion and the patch.
It's good that we caught that point about the javadoc, because to me they sound
somewhat contradictory and may point to possible code issues. It is regarding
the case where entity id prefix is not used for certain types of entities. In
that case, what do we say users should specify to accomplish pagination? Should
they do fromIdPrefix = 0 (default) and the fromId, or should they not specify
fromIdPrefix at all?
>From Varun's proposal, the fromIdPrefix javadoc seems to suggest only fromId
>may be set, whereas the fromId javadoc says clearly fromId will be ignored if
>fromIdPrefix is not set. The code in {{GenericEntityReader}} ignores fromId if
>fromIdPrefix is not set. Perhaps you are implying that fromIdPrefix should
>still be set in that case?
I think this needs to be clarified. IMO, we should keep the behavior of
requiring fromIdPrefix in all cases, but in those cases where the entity id
prefix is not used, we should require users to specify 0 (default) as the
fromIdPrefix. Otherwise, to allow fromId only would be more confusing. Thoughts?
was (Author: sjlee0):
I'm back at work, and am going over the discussion and the patch.
It's good that we caught that point about the javadoc, because to me they sound
somewhat contradictory and may point to possible code issues. It is regarding
the case where entity id prefix is not used for certain types of entities. In
that case, what do we say users should specify to accomplish pagination? Should
they do fromIdPrefix = 0 (default) and the fromId, or should they not specify
fromIdPrefix at all?
>From Varun's proposal, the fromIdPrefix javadoc seems to suggest only fromId
>may be set, whereas the fromId javadoc says clearly fromId will be ignored if
>fromIdPrefix is not set. The code in {{GenericEntityReader}} ignores fromId if
>fromIdPrefix is not set.
I think this needs to be clarified. IMO, we should keep the behavior of
requiring fromIdPrefix in all cases, but in those cases where the entity id
prefix is not used, we should require users to specify 0 (default) as the
fromIdPrefix. Otherwise, to allow fromId only would be more confusing. Thoughts?
> [Atsv2] Reader side changes for entity prefix and support for pagination via
> additional filters
> -----------------------------------------------------------------------------------------------
>
> Key: YARN-5585
> URL: https://issues.apache.org/jira/browse/YARN-5585
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelinereader
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Priority: Critical
> Labels: yarn-5355-merge-blocker
> Attachments: 0001-YARN-5585.patch, YARN-5585-YARN-5355.0001.patch,
> YARN-5585-YARN-5355.0002.patch, YARN-5585-YARN-5355.0003.patch,
> YARN-5585-YARN-5355.0004.patch, YARN-5585-YARN-5355.0005.patch,
> YARN-5585-workaround.patch, YARN-5585.v0.patch
>
>
> TimelineReader REST API's provides lot of filters to retrieve the
> applications. Along with those, it would be good to add new filter i.e fromId
> so that entities can be retrieved after the fromId.
> Current Behavior : Default limit is set to 100. If there are 1000 entities
> then REST call gives first/last 100 entities. How to retrieve next set of 100
> entities i.e 101 to 200 OR 900 to 801?
> Example : If applications are stored database, app-1 app-2 ... app-10.
> *getApps?limit=5* gives app-1 to app-5. But to retrieve next 5 apps, there is
> no way to achieve this.
> So proposal is to have fromId in the filter like
> *getApps?limit=5&&fromId=app-5* which gives list of apps from app-6 to
> app-10.
> Since ATS is targeting large number of entities storage, it is very common
> use case to get next set of entities using fromId rather than querying all
> the entites. This is very useful for pagination in web UI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
