[
https://issues.apache.org/jira/browse/YARN-2902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15798347#comment-15798347
]
Jason Lowe commented on YARN-2902:
----------------------------------
bq. In trunk we "ignore" a non existing directory in delete_as_user() whan the
stat returns an ENOENT we do not do that in branch-2. I tracked it back to
the backport of this jira into branch-2. The native code part of the change was
not ported back into branch-2.
I'm not seeing that. The "backport" for branch-2 was a cherry-pick:
{noformat}
commit c75d8b164f05033d0c6ed4876cf0b8d57224aa8c
Author: Jason Lowe <[email protected]>
Date: Thu Oct 29 16:33:29 2015 +0000
YARN-2902. Killing a container that is localizing can orphan resources in
the DOWNLOADING state. Contributed by Varun Saxena
(cherry picked from commit e2267de2076245bd9857f6a30e3c731df017fef8)
{noformat}
And the diff between trunk and branch-2 shows no difference at all in the
delete_as_user function.
Ah, I believe you mean branch-2.6 instead of branch-2. There is a huge
difference between trunk and branch-2.6 for delete_as_user, and I agree it
appears the ENOENT change was dropped in the 2.6 patch.
bq. If it was an oversight does this require a new jira to backport the native
code or does it get handled as an addendum to this one.
It would be a new JIRA against 2.6.4. This change has already shipped.
> Killing a container that is localizing can orphan resources in the
> DOWNLOADING state
> ------------------------------------------------------------------------------------
>
> Key: YARN-2902
> URL: https://issues.apache.org/jira/browse/YARN-2902
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Affects Versions: 2.5.0
> Reporter: Jason Lowe
> Assignee: Varun Saxena
> Fix For: 2.8.0, 2.7.2, 2.6.4, 3.0.0-alpha1
>
> Attachments: YARN-2902-branch-2.6.01.patch, YARN-2902.002.patch,
> YARN-2902.03.patch, YARN-2902.04.patch, YARN-2902.05.patch,
> YARN-2902.06.patch, YARN-2902.07.patch, YARN-2902.08.patch,
> YARN-2902.09.patch, YARN-2902.10.patch, YARN-2902.11.patch, YARN-2902.patch
>
>
> If a container is in the process of localizing when it is stopped/killed then
> resources are left in the DOWNLOADING state. If no other container comes
> along and requests these resources they linger around with no reference
> counts but aren't cleaned up during normal cache cleanup scans since it will
> never delete resources in the DOWNLOADING state even if their reference count
> is zero.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
