[
https://issues.apache.org/jira/browse/YARN-6040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15798997#comment-15798997
]
Arun Suresh commented on YARN-6040:
-----------------------------------
Thanks for the patch [~leftnoteasy],
Couple of comments:
# Maybe rename PendingAsk::allocationNumber to PendingAsk::count / cardinality ?
# From your comment, it seems you are planning on moving canDelayTo() method to
a separate policy ? I was thinking the PlacementSet itself would encapsulate
the delay scheduling policy, but we can discuss that later.
# In the FSPreemptionThread::run() method, the potentialNodes (line 104 in the
patch), you should be doing a getNodesByResourceName() on the rack name. I
understand though that it requires adding the resourcename into the PendingAsk.
> Remove usage of ResourceRequest from AppSchedulerInfo /
> SchedulerApplicationAttempt
> -----------------------------------------------------------------------------------
>
> Key: YARN-6040
> URL: https://issues.apache.org/jira/browse/YARN-6040
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-6040.001.patch, YARN-6040.002.patch,
> YARN-6040.003.patch, YARN-6040.004.patch
>
>
> As mentioned by YARN-5906, currently schedulers are using ResourceRequest
> heavily so it will be very hard to adopt the new PowerfulResourceRequest
> (YARN-4902).
> This JIRA is the 2nd step of refactoring, which remove usage of
> ResourceRequest from AppSchedulingInfo / SchedulerApplicationAttempt. Instead
> of returning ResourceRequest, it returns a lightweight and API-independent
> object - {{PendingAsk}}.
> The only remained ResourceRequest API of AppSchedulingInfo will be used by
> web service to get list of ResourceRequests.
> So after this patch, usage of ResourceRequest will be isolated inside
> AppSchedulingInfo, so it will be more flexible to update internal data
> structure and upgrade old ResourceRequest API to new.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
