[
https://issues.apache.org/jira/browse/YARN-5959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15799512#comment-15799512
]
Wangda Tan commented on YARN-5959:
----------------------------------
Thanks [~asuresh] for update the patch, generally looks good, some additional
minor suggestions:
1) Can we make scheduler.allocate to have a single ContainerUpdateRequests,
which include 4 lists (increase/decrease/promotion/demotion) instead of making
all of them become top-level parameter, similarly for Allocation.
2) AMS: can we move 4 invokes of {{addToUpdatedContainers}} and 1
{{addToUpdateContainerErrors}} to a separate method considering the long method.
3) Remove unused imports of OCAAMS
4) There's a duplicated method {{createRmContainer}} in AbstractYarnScheduler
and OCAAMS, could we:
- Move it to SchedulerUtils?
- And in addition, it will only allocate OpportunisticContainer, so could you
rename to createOpportuniscRMContainer. I'm asking this because it cannot
guarantee atomic of app and node, I want to make sure no guaranteed container
allocation uses this method.
5) RMContainerImpl:
- Use volatile to avoid synchronized lock for set/getContainer? Because all
other methods are using R/W lock.
> RM changes to support change of container ExecutionType
> -------------------------------------------------------
>
> Key: YARN-5959
> URL: https://issues.apache.org/jira/browse/YARN-5959
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-5959-YARN-5085.001.patch,
> YARN-5959-YARN-5085.002.patch, YARN-5959-YARN-5085.003.patch,
> YARN-5959.combined.001.patch, YARN-5959.wip.002.patch,
> YARN-5959.wip.003.patch, YARN-5959.wip.patch
>
>
> RM side changes to allow an AM to ask for change of ExecutionType.
> Currently, there are two cases:
> # *Promotion* : OPPORTUNISTIC to GUARANTEED.
> # *Demotion* : GUARANTEED to OPPORTUNISTIC.
> This is similar in YARN-1197 which allows for change in Container resources.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
