[ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15800030#comment-15800030 ]
Varun Saxena commented on YARN-6027: ------------------------------------ bq. We could consider the fromId as (user + flow), right? Yes, we can do that. Pagination would require specifying both flow and user anyways. Although, the current order of row key means that same flow executed by different users may not come in a sequence from backend. In UI though, would user prefer same flow name appearing together if run with different users (when we are accessing UI with admin user) ? Frankly I do not necessarily have a strong case for changing the order other than this point. I guess once it becomes clear that flow is differentiated by user as well, even this should be fine. I do acknowledge that pagination can still be achieved with current structure of row key. By the way, an additional point is that we will have to either introduce delimiter or provide 2 filters à la fromIdPrefix and fromId to achieve it. And if we use delimiters, we will have to encode or escape delimiter as well if its part of user (as both user and flow are variable length strings). > Support fromId for flows/flowrun apps > ------------------------------------- > > Key: YARN-6027 > URL: https://issues.apache.org/jira/browse/YARN-6027 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver > Reporter: Rohith Sharma K S > Assignee: Rohith Sharma K S > Labels: yarn-5355-merge-blocker > > In YARN-5585 , fromId is supported for retrieving entities. We need similar > filter for flows/flowRun apps and flow run and flow as well. > Along with supporting fromId, this JIRA should also discuss following points > * Should we throw an exception for entities/entity retrieval if duplicates > found? > * TimelieEntity : > ** Should equals method also check for idPrefix? > ** Does idPrefix is part of identifiers? -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org