[
https://issues.apache.org/jira/browse/YARN-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Junping Du updated YARN-4158:
-----------------------------
Fix Version/s: 2.8.0
> Remove duplicate close for LogWriter in
> AppLogAggregatorImpl#uploadLogsForContainers
> ------------------------------------------------------------------------------------
>
> Key: YARN-4158
> URL: https://issues.apache.org/jira/browse/YARN-4158
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.7.0
> Reporter: zhihai xu
> Assignee: zhihai xu
> Priority: Minor
> Labels: cleanup
> Fix For: 2.8.0, 2.7.2, 3.0.0-alpha1
>
> Attachments: YARN-4158.000.patch
>
>
> Remove duplicate {{close}} for {{LogWriter}} in
> {{AppLogAggregatorImpl#uploadLogsForContainers}}
> {{writer.close()}} was called twice in {{uploadLogsForContainers}}. One is
> called at the middle of the function and the other one is called at finally
> block. It will be better to just close {{writer}} once. Also {{LogWriter}}
> didn't implement java.io.Closeable interface. So we can't suppose
> {{LogWriter.close}} is idempotent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
