[ 
https://issues.apache.org/jira/browse/YARN-5927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15808729#comment-15808729
 ] 

Karthik Kambatla commented on YARN-5927:
----------------------------------------

Just barely looked at the patch. In the latest patch, the sleeps are for 10 ms, 
but the accounting increments the timeoutSecs by 2 every time. 

Will take another look soon. 

> BaseContainerManagerTest::waitForNMContainerState timeout accounting is not 
> accurate
> ------------------------------------------------------------------------------------
>
>                 Key: YARN-5927
>                 URL: https://issues.apache.org/jira/browse/YARN-5927
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Miklos Szegedi
>            Assignee: Kai Sasaki
>            Priority: Trivial
>              Labels: newbie
>         Attachments: YARN-5917.01.patch, YARN-5917.02.patch
>
>
> See below that timeoutSecs is increased twice. We also do a sleep right away 
> before even checking the observed value.
> {code}
>     do {
>       Thread.sleep(2000);
>  ...
>       timeoutSecs += 2;
>     } while (!finalStates.contains(currentState)
>         && timeoutSecs++ < timeOutMax);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to