[ 
https://issues.apache.org/jira/browse/YARN-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15813393#comment-15813393
 ] 

Sangjin Lee commented on YARN-5980:
-----------------------------------

Thanks [~vrushalic] for your patch! Most of the comments are minor (except the 
last one).

- l.184: it might be better if the URL is enclosed in parenthesis: "for your 
setup (http://...)."
- l.191: "on standalone HBase" -> "on the standalone HBase setup"
- l.192: "they persist" -> "it persists"
- l.194: for consistency, let's use the fixed width font for hbase-site.xml: 
`hbase-site.xml`
- l.195: likewise, the hbase.rootdir -> the `hbase.rootdir` property
- l.196: likewise, hbase.cluster.distributed -> `hbase.cluster.distributed`
- l.212: let's add a period at the end
- l.234: Have we changed the coprocessor to a dynamic one? I don't think we 
made that change (yet)?


> Update documentation for single node hbase deploy
> -------------------------------------------------
>
>                 Key: YARN-5980
>                 URL: https://issues.apache.org/jira/browse/YARN-5980
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Vrushali C
>            Assignee: Vrushali C
>              Labels: yarn-5355-merge-blocker
>         Attachments: YARN-5980.001.patch, YARN-5980.002.patch, 
> YARN-5980.003.patch
>
>
> Per HBASE-17272, a single node hbase deployment (single jvm running daemons + 
> hdfs writes) will be added to hbase shortly. 
> We should update the timeline service documentation in the setup/deployment 
> context accordingly, this will help users who are a bit wary of hbase 
> deployments help get started with timeline service more easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to