[
https://issues.apache.org/jira/browse/YARN-6011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15813533#comment-15813533
]
Junping Du commented on YARN-6011:
----------------------------------
Thanks [~xgong] for delivering the patch. A couple of comments:
1. For generating URI embed in response of getContainerLogsInfo, I saw some
very similar one in other places, like: getLogs(). Can we refactor the code a
bit to reuse the same logic?
2. For getContainerLogsInfo(), if an app is not in running or finished state,
here we will return bad request. However, I remember in our ATS implementation,
RM after restart could send regressioned application state event to ATS, like
app creation event to ATS which was running before. Can you double check ATS's
app status won't have regression? Otherwise, we shouldn't just simply return a
bad request.
3. For getContainerLogMeta(), I remember I have some previous comments on
refactor code (consolidate similar logic, especially log reader) in previous
JIRAs. How's going with that effort? If that effort is not a short term priory
for you, please add a TODO here - may be someone else read this part of code
could help on that.
Other looks good to me.
> Add a new web service to list the files on a container in AHSWebService
> -----------------------------------------------------------------------
>
> Key: YARN-6011
> URL: https://issues.apache.org/jira/browse/YARN-6011
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-6011.1.patch, YARN-6011.2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
