[ 
https://issues.apache.org/jira/browse/YARN-5556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815760#comment-15815760
 ] 

Naganarasimha G R commented on YARN-5556:
-----------------------------------------

Had tested the changes in the local setup, seems to be fine. Few nits which i 
was able to think of were 
* "root.Q1.Q1b seems to be deleted but the queue is not yet in stopped state" 
error message can be told as removed in the updated xml than deleted.
* {{"refreshQueues: java.io.IOException: Failed to re-init queues"}} is the 
message shown in console though down in the stacktrace exact message is 
captured. Better to append the exception message to {{"Failed to re-init 
queues"}} at {{CapacityScheduler.reinitialize}} on exception
* documentation needs to be updated, can either raise a new jira or add as part 
of this jira for the steps to be delete the Queue in CS

Can work on this along with other comments .


> Support for deleting queues without requiring a RM restart
> ----------------------------------------------------------
>
>                 Key: YARN-5556
>                 URL: https://issues.apache.org/jira/browse/YARN-5556
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>            Reporter: Xuan Gong
>            Assignee: Naganarasimha G R
>         Attachments: YARN-5556.v1.001.patch, YARN-5556.v1.002.patch, 
> YARN-5556.v1.003.patch, YARN-5556.v1.004.patch, YARN-5556.v2.005.patch
>
>
> Today, we could add or modify queues without restarting the RM, via a CS 
> refresh. But for deleting queue, we have to restart the ResourceManager. We 
> could support for deleting queues without requiring a RM restart



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to