[
https://issues.apache.org/jira/browse/YARN-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15816887#comment-15816887
]
Karthik Kambatla commented on YARN-5831:
----------------------------------------
Thanks for updating the patch, Yufei. The patch looks mostly good. A couple of
minor comments:
# QueueManager#createNewQueues: What do you think of calling
queue.reinit(false) in FSQueue constructor instead of here. I feel that might
be less error-prone. We won't need the kind of changes you had to make in
TestFSLeafQueue.
# QueueManager#initialize: Should the call to reinit be recursive and called
after creating "root.default" queue. In practice, this might not matter.
> Propagate allowPreemptionFrom flag all the way down to the app
> --------------------------------------------------------------
>
> Key: YARN-5831
> URL: https://issues.apache.org/jira/browse/YARN-5831
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler
> Reporter: Karthik Kambatla
> Assignee: Yufei Gu
> Attachments: YARN-5831.001.patch, YARN-5831.002.patch,
> YARN-5831.003.patch
>
>
> FairScheduler allows disallowing preemption from a queue. When checking if
> preemption for an application is allowed, the new preemption code recurses
> all the way to the root queue to check this flag.
> Propagating this information all the way to the app will be more efficient.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
