[
https://issues.apache.org/jira/browse/YARN-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15816923#comment-15816923
]
Karthik Kambatla commented on YARN-4212:
----------------------------------------
Thanks for updating the patch here, Yufei.
Comments:
# SchedulingPolicy
## Can we rename the method to {{alllowedParentPolicies()}}.
## Also, can it be {{Set<SchedulingPolicy>}} instead?
# QueueManager:
## createNewQueues has a couple of spurious new lines.
## Does checkIfParentPolicyAllowed need to be recursive? It seems to be called
from createQueue only now? If every queue has a valid parent, wouldn't that
suffice?
## Also, shouldn't we check parent policy on updateAllocationConfiguration as
well? If that is the case, are we better off doing this check on
AllocationConfiguration before we update it? That way, the cluster could
continue running while the admin deals with the logged errors and fix the alloc
file?
## In updateAllocationConfiguration, the added code seems to set
SchedulingPolicy for all queues and not just root and root.default. What am I
missing?
# In the test, we seem to verify only the policies on initial load. Should we
add another test that verifies updating the alloc file?
> FairScheduler: Parent queues is not allowed to be 'Fair' policy if its
> children have the "drf" policy
> -----------------------------------------------------------------------------------------------------
>
> Key: YARN-4212
> URL: https://issues.apache.org/jira/browse/YARN-4212
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Arun Suresh
> Assignee: Yufei Gu
> Labels: fairscheduler
> Attachments: YARN-4212.002.patch, YARN-4212.003.patch,
> YARN-4212.004.patch, YARN-4212.005.patch, YARN-4212.1.patch
>
>
> The Fair Scheduler, while performing a {{recomputeShares()}} during an
> {{update()}} call, uses the parent queues policy to distribute shares to its
> children.
> If the parent queues policy is 'fair', it only computes weight for memory and
> sets the vcores fair share of its children to 0.
> Assuming a situation where we have 1 parent queue with policy 'fair' and
> multiple leaf queues with policy 'drf', Any app submitted to the child queues
> with vcore requirement > 1 will always be above fairshare, since during the
> recomputeShare process, the child queues were all assigned 0 for fairshare
> vcores.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
