[
https://issues.apache.org/jira/browse/YARN-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15820719#comment-15820719
]
Sunil G commented on YARN-6033:
-------------------------------
Thanks [~vvasudev] for patch
Few doubts/comments:
1. one doubt. In {{trim_comment}}, strchr will get first occurrence of the
comment character rt, so it ll be replaced with a '/0'. What if two comment
chars are present in the start of line?
2.
bq.merge_sections((struct section *) existing_section, new_section, 1);
In existing section, will it have enough memory to hold new section?
3.
bq.struct section *new_section = read_section(conf_file);
In read_config, if below code returns null, we will still go and do realloc for
increase sectionentry details.
> Add support for sections in container-executor configuration file
> -----------------------------------------------------------------
>
> Key: YARN-6033
> URL: https://issues.apache.org/jira/browse/YARN-6033
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Attachments: YARN-6033-YARN-5673.001.patch,
> YARN-6033-YARN-5673.002.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
