[ 
https://issues.apache.org/jira/browse/YARN-6016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822329#comment-15822329
 ] 

Botong Huang commented on YARN-6016:
------------------------------------

Hi Subru, I've taken a look at {{TestAMRMProxy}}. There is a relevant test 
{{testE2ETokenRenewal}}. However, this test is really testing that AM can 
receive the new AMRMToken when AMRMProxy rolls its master key. 

Here in this Jira, the problem is between RM and AMRMProxy, when RM issues a 
new token,AMRMProxy should intercept it without forwarding it to AM. It is 
non-trivial to add it into {{TestAMRMProxy}} because both AMRMProxy and RM 
share the same config for rolling interval. 

I added tests in {{TestAMRMProxyService}} to cover this case. I also modified 
the test name and comments in {{TestAMRMProxy}} for clarification. Please see 
v3.patch

> Bugs in AMRMProxy handling (local)AMRMToken
> -------------------------------------------
>
>                 Key: YARN-6016
>                 URL: https://issues.apache.org/jira/browse/YARN-6016
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: federation
>            Reporter: Botong Huang
>            Assignee: Botong Huang
>            Priority: Minor
>         Attachments: YARN-6016.v1.patch, YARN-6016.v2.patch
>
>
> Two AMRMProxy bugs: 
> First, the AMRMToken from RM should not be propagated to AM, since AMRMProxy 
> will create a local AMRMToken for it. 
> Second, the AMRMProxy Context is now parse the localAMRMTokenKeyId from 
> amrmToken, but should be from localAmrmToken. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to