[
https://issues.apache.org/jira/browse/YARN-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826542#comment-15826542
]
Karthik Kambatla edited comment on YARN-5831 at 1/17/17 6:22 PM:
-----------------------------------------------------------------
Patch is looking good. A few nits:
# FSQueue#reinit javadoc for param recursive looks more like the one people use
for return. How about "whether child queues should be reinitialized
recursively"?
# QueueManager
## Line 80: s/renitialization/reinitialize
## Line 499: s/Initializing/Initialize
was (Author: kasha):
Patch is looking good. A few nits:
# FSQueue#reinit javadoc for param recursive looks more like the one people use
for return. How about "whether child queues should reinitialized recursively"?
# QueueManager
## Line 80: s/renitialization/reinitialize
## Line 499: s/Initializing/Initialize
> Propagate allowPreemptionFrom flag all the way down to the app
> --------------------------------------------------------------
>
> Key: YARN-5831
> URL: https://issues.apache.org/jira/browse/YARN-5831
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler
> Reporter: Karthik Kambatla
> Assignee: Yufei Gu
> Attachments: YARN-5831.001.patch, YARN-5831.002.patch,
> YARN-5831.003.patch, YARN-5831.004.patch
>
>
> FairScheduler allows disallowing preemption from a queue. When checking if
> preemption for an application is allowed, the new preemption code recurses
> all the way to the root queue to check this flag.
> Propagating this information all the way to the app will be more efficient.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
