[
https://issues.apache.org/jira/browse/YARN-6076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830515#comment-15830515
]
Daniel Templeton commented on YARN-6076:
----------------------------------------
Since I don't remember all the details of YARN-4752, so I'm going to do the
review again from scratch. :)
* {{Resource.isNone()}} is missing Javadoc
* I really hate {{if (null != ps)}}. This isn't C++. But that's not a fight
to have on this JIRA.
* {{FSAppAttempt. getNextResourceRequest()}} is missing Javadoc
Looking at a diff of the two patches, I see nothing of substance that's
different between them. Maybe file a JIRA to add the missing Javadoc and leave
it for a newbie?
> Backport YARN-4752 (FS preemption changes) to branch-2
> ------------------------------------------------------
>
> Key: YARN-6076
> URL: https://issues.apache.org/jira/browse/YARN-6076
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
> Affects Versions: 2.8.0
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: yarn-6076-branch-2.1.patch, yarn-6076-branch-2.1.patch
>
>
> YARN-4752 was merged to trunk a while ago, and has been stable. Creating this
> JIRA to merge it branch-2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
