[
https://issues.apache.org/jira/browse/YARN-6099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832265#comment-15832265
]
Junping Du commented on YARN-6099:
----------------------------------
Thanks [~xgong] for this code refactor effort. The code does look much cleaner!
Most changes looks fine to me. Except one: for new added class -
PerContainerLogFileInfo, because we are put it in generic type container like:
List, we should override hashCode() and equals(). Otherwise, it could behave
strange in some corner cases.
Also, please check if findbug warning is related. If so, please fix it.
Other looks fine to me.
> Improve webservice to list aggregated log files
> -----------------------------------------------
>
> Key: YARN-6099
> URL: https://issues.apache.org/jira/browse/YARN-6099
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-6099.1.patch, YARN-6099.branch-2.v2.patch,
> YARN-6099.trunk.1.patch, YARN-6099.trunk.2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
