[
https://issues.apache.org/jira/browse/YARN-6123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839764#comment-15839764
]
Sunil G commented on YARN-6123:
-------------------------------
1. {{PriorityUtilizationQueueOrderingPolicy.setQueues}} Do we need to make this
method under writelock to protect {{queues}} getting changed at runtime while
{{getAssignmentIterator}} is accessing the same (thought its a copy).
2. Few minor comments in test case:
a) {{bQ.getChildQueues().size()}} could we check this before calling
reinitialize once.
b) In {{checkEqualsToQueueSet}}, I think it may be better to check whether size
of {{queues}} and {{queueNames}} are equal and that can be a common assert in
side checkEqualsToQueueSet method. So we can avoid queue size assert in common
test case.
> [YARN-5864] Add a test to make sure queues of orderingPolicy will be updated
> when childQueues added or removed.
> ---------------------------------------------------------------------------------------------------------------
>
> Key: YARN-6123
> URL: https://issues.apache.org/jira/browse/YARN-6123
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-6123.001.patch
>
>
> YARN-5864 added queue ordering policy to ParentQueue, we need to make sure
> queues of QueueOrderingPolicy will be updated when any changes made for child
> queues.
> We need to add a test to make sure it works.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
