[ 
https://issues.apache.org/jira/browse/YARN-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13701023#comment-13701023
 ] 

Alejandro Abdelnur commented on YARN-521:
-----------------------------------------

* Javadocs on AMRMClient.ContainerRequest class are not correct, @params should 
go in the constructor javadoc

* AMRMClient.ContainerRequest constructor. the {{(!relaxLocality && racks == 
null && nodes == null) }} check seems incomplete, what happen if giving a [0] 
array or an array with NULL values. I know we are not doing these kind of check 
in other places, so maybe a diff JIRA to do them in all the AMRMClient API?

* in AMRMClientImpl.addContainerRequest() it seems we are doing more than the 
JIRA accounts for. renaming allRacks to dedupedRacks & inferring racks from 
nodes. Unless I'm missing something, this should be done in a diff JIRA.

                
> Augment AM - RM client module to be able to request containers only at 
> specific locations
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-521
>                 URL: https://issues.apache.org/jira/browse/YARN-521
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api
>    Affects Versions: 2.0.3-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-521.patch
>
>
> When YARN-392 and YARN-398 are completed, it would be good for AMRMClient to 
> offer an easy way to access their functionality

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to