[
https://issues.apache.org/jira/browse/YARN-6138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849679#comment-15849679
]
Sunil G commented on YARN-6138:
-------------------------------
Thanks [~mradmila] for sharing the patch. Few general comments
1) Please follow patch naming convention as per this link.
https://wiki.apache.org/hadoop/HowToContribute#Naming_your_patch
This will help you to compile patch against respective branch. Also if its a
general issue, you can give patch against trunk first.
2) Your patch has same file changes 3 times. Please help to upload a correct
formatted patch. git commands could help here.
3) I am not very sure why a call back method needs to be exposed for preemption
message. Doesnt it need to a part of container completed etc ? Could you please
add some more details here, why this change is needed?
> AMRMClientAsync does not surface preemption message
> ---------------------------------------------------
>
> Key: YARN-6138
> URL: https://issues.apache.org/jira/browse/YARN-6138
> Project: Hadoop YARN
> Issue Type: Bug
> Components: yarn
> Affects Versions: 2.7.2
> Reporter: Marko Radmilac
> Priority: Minor
> Attachments: amrmpatch.txt
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> While AMRMClientAsync does pass on updated nodes and other messages from the
> AMRM channel, it does not pass information about preemption.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
