[
https://issues.apache.org/jira/browse/YARN-6108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849870#comment-15849870
]
Junping Du commented on YARN-6108:
----------------------------------
Thanks [~xgong] for addressing my above comments. Quick go through latest patch
and have several comments so far:
1. Shall we move YarnWebServiceUtils into webapp.util package just like
WebAppUtils?
2. YarnWebServiceParams.NM_NODENAME seems a bit redundancy, may be rename to
NM_ID or NM_NODEID?
3.
{noformat}
+ String resURI = JOINER.join(getAbsoluteNMWebAddress(nodeHttpAddress),
+ NM_DOWNLOAD_URI_STR, uri);
{noformat}
Sound like nodeHttpAddress is still possible to be null. If so,
getAbsoluteNMWebAddress() will throw NPE in this case. It is better to handle
null case explicitly here.
> Improve AHS webservice to accept NM address as a parameter to get container
> logs
> --------------------------------------------------------------------------------
>
> Key: YARN-6108
> URL: https://issues.apache.org/jira/browse/YARN-6108
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-6108.1.patch, YARN-6108.2.patch,
> YARN-6108.branch-2.v1.patch
>
>
> Currently, if we want to get container log for running application, we need
> to get NM web address from AHS which we need to enable
> yarn.timeline-service.generic-application-history.save-non-am-container-meta-info
> for non-am containers. But, in most of time, we will disable this
> configuration for ATS performance purpose. In this case, it is impossible for
> us to get the logs for non-am container in a running application.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
