[
https://issues.apache.org/jira/browse/YARN-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15850363#comment-15850363
]
Wangda Tan commented on YARN-5951:
----------------------------------
Thanks [~jhung] for updating the patch.
Overall patch looks good.
Few comments for latest patch:
1) Suggest to remove
{{DERBY_CS_CONF_PROVIDER}}/{{StoreBasedCSConfigurationProvider}}/{{DerbyConfigurationStore}}/{{YarnConfigurationStore}}
from the patch, better to add them when we add the first store-based
implementation.
2) Like other configs, better to add a DEFAULT_CS_CONF_PROVIDER and point it to
FILE_CS_CONF_PROVIDER.
> Changes to allow CapacityScheduler to use configuration store
> -------------------------------------------------------------
>
> Key: YARN-5951
> URL: https://issues.apache.org/jira/browse/YARN-5951
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jonathan Hung
> Assignee: Jonathan Hung
> Attachments: YARN-5951-YARN-5734.001.patch,
> YARN-5951-YARN-5734.002.patch
>
>
> EDIT: changing this ticket. Found that the CapacityStoreConfigurationProvider
> is not necessary, since we can just grab a Configuration object from
> StoreConfigurationProvider with type "SCHEDULER" and create a
> CapacitySchedulerConfiguration from it.
> This ticket will track changes needed for integrating other components to be
> used by the capacity scheduler.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
