[
https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naganarasimha G R updated YARN-4675:
------------------------------------
Attachment: YARN-4675.v2.006.patch
Thanks for the detailed review comments [~varun_saxena], please find the
updated patch addressing the comments,
bq. In TimelineClientImpl#serviceInit, we check if timeline service version is
v2 and if not throw IOException. Here we can simply call
YarnConfiguration#timelineServiceV2Enabled to make the check.
if we are checking in this fashion we need to use negation "!" and negation
will return true even when {{timelineServiceEnabled(conf)}} fails in
timelineServiceV2Enabled check.
bq. However, we should still make a check for timeline service v2 flag in
TimelineV2ClientImpl and v1 flag in TimelineClientImpl (it can be initialized
with false in constructor), just in case init is not called.
IMO no need to do unnecessary checks as anyway client is bound to fail if
service is not initialized
bq. are we planning to move around classes in this patch itself as per Li's
comment so the impl constructors are not called directly?
As discussed later in the meeting may be not required as part of this.
> Reorganize TimeClientImpl into TimeClientV1Impl and TimeClientV2Impl
> --------------------------------------------------------------------
>
> Key: YARN-4675
> URL: https://issues.apache.org/jira/browse/YARN-4675
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Labels: YARN-5355, yarn-5355-merge-blocker
> Attachments: YARN-4675.v2.002.patch, YARN-4675.v2.003.patch,
> YARN-4675.v2.004.patch, YARN-4675.v2.005.patch, YARN-4675.v2.006.patch,
> YARN-4675-YARN-2928.v1.001.patch
>
>
> We need to reorganize TimeClientImpl into TimeClientV1Impl ,
> TimeClientV2Impl and if required a base class, so that its clear which part
> of the code belongs to which version and thus better maintainable.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
