[ 
https://issues.apache.org/jira/browse/YARN-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854418#comment-15854418
 ] 

Daniel Templeton edited comment on YARN-6150 at 2/6/17 5:31 PM:
----------------------------------------------------------------

Looks generally good to me.  One issue I see is that I think you inverted the 
check for complete on the container--you're now looping while it's complete 
instead of until it's complete.


was (Author: templedf):
Looks generally good to me.  One issue I see is that I think you inverted the 
check for complete on the container--you're now loop while it's complete 
instead of until it's complete.

> TestContainerManagerSecurity tests for Yarn Server are flakey
> -------------------------------------------------------------
>
>                 Key: YARN-6150
>                 URL: https://issues.apache.org/jira/browse/YARN-6150
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: yarn
>            Reporter: Daniel Sturman
>         Attachments: YARN-6150.001.patch
>
>
> Repeated runs of 
> {{org.apache.hadoop.yarn.server.TestContainerManagedSecurity}} can either 
> pass or fail on repeated runs on the same codebase.  Also, the two runs (one 
> in secure mode, one without security) aren't well labeled in JUnit.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to