[ 
https://issues.apache.org/jira/browse/YARN-6137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854969#comment-15854969
 ] 

Jason Lowe commented on YARN-6137:
----------------------------------

Thanks for the patch!  I think overall the approach is reasonable.

bq. One thing I'm not sure about is if yarn client itself should be thread safe.

I think it's reasonable to add a bit of synchronization just around the part 
where we try to init the timeline client so we don't have more than one thread 
doing it.

For this code, shouldn't we just be checking if the client isn't null?  The 
enabled boolean check looks redundant to me.
{code}
    if (timelineServiceEnabled && (timelineClient != null)) {
{code}

I didn't look into the unit test failure, but it looks related.

> Yarn client implicitly invoke ATS client which accesses HDFS
> ------------------------------------------------------------
>
>                 Key: YARN-6137
>                 URL: https://issues.apache.org/jira/browse/YARN-6137
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Yesha Vora
>            Assignee: Li Lu
>         Attachments: YARN-6137-trunk.001.patch
>
>
> Yarn is implicitly trying to invoke ATS Client even though client does not 
> need it. and ATSClient code is trying to access hdfs. Due to that service is 
> hitting GSS exception. 
> Yarnclient is implicitly creating ats client that tries to access Hdfs.
> All servers that use yarnclient cannot be expected to change to accommodate 
> this behavior.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to