[ 
https://issues.apache.org/jira/browse/YARN-6144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854987#comment-15854987
 ] 

Miklos Szegedi commented on YARN-6144:
--------------------------------------

About checkstyle: this is a long function that is not a regression of this 
change.
hadoop.yarn.server.resourcemanager.TestRMRestart should be 
https://issues.apache.org/jira/browse/YARN-5548, a flaky test.
I could not repro 
hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation locally

> FairScheduler: preempted resources can become negative
> ------------------------------------------------------
>
>                 Key: YARN-6144
>                 URL: https://issues.apache.org/jira/browse/YARN-6144
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler, resourcemanager
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Miklos Szegedi
>            Assignee: Miklos Szegedi
>            Priority: Blocker
>         Attachments: Screen Shot 2017-02-02 at 12.49.14 PM.png, 
> YARN-6144.000.patch, YARN-6144.001.patch
>
>
> {{preemptContainers()}} calls {{trackContainerForPreemption()}} to collect 
> the list of containers and resources that were preempted for an application. 
> Later the list is reduced when {{containerCompleted()}} calls 
> {{untrackContainerForPreemption()}}. The bug is that the resource variable 
> {{preemptedResources}} is subtracted, not just when the container was 
> preempted but also when it has completed successfully. This causes that we 
> return an incorrect value in {{getResourceUsage()}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to