[
https://issues.apache.org/jira/browse/YARN-6113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857957#comment-15857957
]
Junping Du commented on YARN-6113:
----------------------------------
Patch looks good in over all. Just a minor one, logic within
removeSpecifiedQueryParameter() sounds like very similar to
WebAppUtils.getURLEncodedQueryString() - the only different is to remove
specific parameter. Can we consolidate two methods in some way to remove
duplicated code?
Other looks fine to me.
> re-direct NM Web Service to get container logs for finished applications
> ------------------------------------------------------------------------
>
> Key: YARN-6113
> URL: https://issues.apache.org/jira/browse/YARN-6113
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-6113.branch-2.v1.patch,
> YARN-6113.branch-2.v2.patch, YARN-6113.branch-2.v3.patch,
> YARN-6113.trunk.v2.patch, YARN-6113.trunk.v3.patch
>
>
> In NM web ui, when we try to get container logs for finished application, it
> would redirect to the log server based on the configuration:
> yarn.log.server.url. We should do the similar thing for NM WebService
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
